[Frontend] Generalise SourceCodeFile class #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
DavidKorczynski
approved these changes
Jan 18, 2025
|
|
||
| class SourceCodeFile(): | ||
| """Class for holding file-specific information.""" | ||
| LANGUAGE: dict[str, Language] = { |
There was a problem hiding this comment.
LANGUAGE is too generic of a name here
| LANGUAGE: dict[str, Language] = { | ||
| 'c': Language(tree_sitter_c.language()), | ||
| 'cpp': Language(tree_sitter_cpp.language()), | ||
| 'c++': Language(tree_sitter_cpp.language()), |
There was a problem hiding this comment.
we should use language constants from constants.py here
| with open(self.source_file, 'rb') as f: | ||
| self.source_content = f.read() | ||
|
|
||
| # Initialization ruotines |
| self.root = self.parser.parse(self.source_content).root_node | ||
|
|
||
| def language_specific_process(self): | ||
| """Dummy function to perform some specific processes in subclasses.""" |
There was a problem hiding this comment.
am not sure if we should use dummy here, or just give documentation as how classes inherit from here should use the function
|
|
||
| logger = logging.getLogger(name=__name__) | ||
|
|
||
|
|
||
| class SourceCodeFile(): | ||
| class CppSourceCodeFile(SourceCodeFile): |
There was a problem hiding this comment.
I prefer to have the language post SourceCodeFile here, this applies to the other classes as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalise the SourceCodeFile classes and simplify some of the frontend logic.